travis: drop node@5, add node@6 - #2283
Merged
Merged
Conversation
Node v6 no longer supports port:undefined, this commit is fixing app.listen() to correctly send port:0 when no port is specified.
bajtos
force-pushed
the
add-node-v6-to-travis
branch
from
May 3, 2016 14:20
d8470eb to
4d7154a
Compare
Contributor
|
LGTM |
This was referenced May 3, 2016
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
node@6as a replacement fornode@5.node@5will become unsupported in few weeks/months and besides it's covered by Jenkins CI, thus I think it's safe to remove.@superkhau please review
/cc @strongloop/loopback-dev